Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add products reviews to schema.org #319

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add products reviews to schema.org #319

wants to merge 1 commit into from
+25 −6

Conversation

rodriciru
Copy link
Contributor

@rodriciru rodriciru commented Jun 9, 2022 •
edited
Loading

Questions Answers
Description? Add customer reviews to product json+ld
Type? improvement
BC breaks? no
Deprecations? no

This change depends on this pull request, as we have the data from somewhere:
PrestaShop/productcomments#140

But for now i add the code to print the reviews

This was referenced Jun 9, 2022
Closed
Open
Open
@rodriciru
Copy link
Contributor Author

Anything i can do?. I dont know if i close the requested changes or what. I new to this github part

NeOMakinG
NeOMakinG previously approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's acceptable for now, but I would like the @Hlavtox advice as he commented something

@Hlavtox
Copy link
Contributor

Hlavtox commented Jul 28, 2022

@NeOMakinG @rodriciru @matks Everything is good with the JSON work, I approve, but let's use the moment to think about unifying the structure.

What if we just require all review modules to provide data in standardized format? So if you swap a review module, all will work.
$product.rating.reviews
$product.rating.total
$product.rating.average

@rodriciru
Copy link
Contributor Author

@NeOMakinG @rodriciru @matks Everything is good with the JSON work, I approve, but let's use the moment to think about unifying the structure.

What if we just require all review modules to provide data in standardized format? So if you swap a review module, all will work. $product.rating.reviews $product.rating.total $product.rating.average

I love standardization.

@matks
Copy link
Contributor

matks commented Aug 1, 2022

I agree unifying would be good 👍 and product.rating looks good enough for me to be used right now

@NeOMakinG
Copy link
Contributor

@Hlavtox so we need to tweak the module itself first?

@aniszr
Copy link

aniszr commented Jun 26, 2023

Hello,
Could you please resolve this branch conflicts and apply the requested changes.

Thanks!

@rodriciru rodriciru requested a review from matks June 27, 2023 13:29
@matks
Copy link
Contributor

matks commented Sep 12, 2023

Hi @ga-devfront can you tell us why you closed this PR? Is it not relevant anymore

Merging this PR was a blocker for PR PrestaShop/productcomments#140

@ga-devfront ga-devfront reopened this Sep 13, 2023
@ga-devfront
Copy link
Collaborator

Hi @ga-devfront can you tell us why you closed this PR? Is it not relevant anymore

Merging this PR was a blocker for PR PrestaShop/productcomments#140

My apologies, it was a handling error on my part when I set up the work for PrestaShopCorp...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hlavtox Hlavtox Hlavtox left review comments

@NeOMakinG NeOMakinG NeOMakinG left review comments

@matks matks Awaiting requested review from matks

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
PR Dashboard
Status: Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rodriciru @Hlavtox @matks @NeOMakinG @aniszr @ga-devfront